-
Notifications
You must be signed in to change notification settings - Fork 7.9k
zend call stack fixing stack limit for macOs arm64. #13319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! The code change looks good to me, but the new comments are redundant with the existing comment bellow them.
We could make the change self-explanatory by merging the code paths. For example (in pseudo code) :
if (pthread_main_np() && !arm64) {
/* existing comment explaining the workaround for older OSX versions */
max_size = 8 * 1024 * 1024;
} else {
max_size = pthread_get_stacksize_np(pthread_self());
}
04cd85a
to
8165853
Compare
should be slightly faster on modern macos edit: fixed a logic error |
8MB sounded a prudent size for older 10.9 macOs release, however with newer mac with arm64, it triggers a stack overflow.
8165853
to
7f770c1
Compare
LGTM 👍 |
8MB sounded a prudent size for older 10.9 macOs release, however with newer mac with arm64, it triggers a stack overflow. close phpGH-13319
8MB sounded a prudent size for older 10.9 macOs release, however with newer mac with arm64, it triggers a stack overflow. close phpGH-13319
8MB sounded a prudent size for older 10.9 macOs release, however with newer mac with arm64, it triggers a stack overflow.