Move PASSWORD constants to stubs #13349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
reviewed
Feb 9, 2024
added 2 commits
February 9, 2024 19:42
Move all remaining PASSWORD constants to stub files Assign string values directly to PHP variables in stubs Wrap all sodium_pwhash function calls and C constants in argon2lib and libsodium version checks
kocsismate
reviewed
Feb 11, 2024
kocsismate
reviewed
Feb 11, 2024
kocsismate
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves a few constants from
password.candsodium_pwshash.cto stub files. This is done by first aligning some of the underlying values in the header files, movingargon2constant registrations right after the first successful algorithm registration and moving the first set of constants from both files to a stub file.@kocsismate This is the last set of constants that I could move into stub files that I mentioned in my other PR (#13312).