UPGRADING: Minor adjustments moving items to appropriate sections #13576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
reviewed
Mar 2, 2024
UPGRADING
Outdated
| @@ -211,8 +220,8 @@ PHP 8.4 UPGRADE NOTES | |||
| or by invoking their constructor directly. | |||
|
|
|||
| - PDO_DBLIB: | |||
| . Fixed setAttribute and getAttribute (SakiTakamachi) | |||
| . Added PdoDbLib class (danack, kocsismate) | |||
| . Fixed setAttribute and getAttribute | |||
There was a problem hiding this comment.
This entry is actually a bit vague. I see it corresponds to #12793
However, that PR did already add an entry for this in the BC section, so this might not be necessary...
There was a problem hiding this comment.
Thank you! I removed that line.
- Moved curl_version()['feature_list'] to New Features - Moved NumberFormatter::ROUND_HALFODD to New Features - Removed contributor names (this pattern only used in the `NEWS` file) - Removed "Fixed setAttribute and getAttribute" as it is covered in another change record
Ayesh
force-pushed
the
UPGRADING_minor-fixes
branch
from
393239b to
3258ec5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEWSfile)