More BCMath performance improvements #14106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The strings are always new, not interned.
SakiTakamachi
approved these changes
May 2, 2024
| @@ -179,9 +177,9 @@ PHP_FUNCTION(bcadd) | |||
| goto cleanup; | |||
| } | |||
|
|
|||
| bc_add (first, second, &result, scale); | |||
| result = bc_add (first, second, scale); | |||
There was a problem hiding this comment.
Suggested change
| result = bc_add (first, second, scale); | |
| bc_num result = bc_add (first, second, scale); |
Maybe can declare and initialize it at the same time and remove the result from the cleanup.
But I'm not sure if it affects performance.
There was a problem hiding this comment.
Good question. I expect this will only make the failure path potentially faster, as it can avoid a call then to the freeing. For the success path I don't think it matters, but I guess feel free to try.
Girgias
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon all previous PRs.
With benchmark from #14076.
Before:
After:
One of the changes here is avoiding initializing and releasing temporary numbers, but only done for the most simple (and common) functions.