Skip to content

8.4 | UPGRADING: various tweaks #15339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2024

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Aug 11, 2024

8.4 | UPGRADING: various tweaks

[skip ci] 8.4 | UPGRADING: add missing entry for DBA resource to object migration

Ref: #14329

P.S.: looks like #14282 also doesn't have a mention, but that PR doesn't appear to have an impact on userland - maybe a NEWS entry ? /cc @nielsdos @cmb69

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
I don't think the internal resource conversion of com_dotnet needs to be in NEWS because NEWS is normally only for user-facing changes. cc @cmb69 ?

@cmb69
Copy link
Member

cmb69 commented Aug 11, 2024

I don't think the internal resource conversion of com_dotnet needs to be in NEWS because NEWS is normally only for user-facing changes.

Agreed.

@jrfnl jrfnl force-pushed the feature/php-8.4-upgrading-tweaks branch from 22cb10c to efc0024 Compare August 11, 2024 10:35
jrfnl added 2 commits August 11, 2024 12:46
…ct migration

Ref: 14329

P.S.: looks like 14282 also doesn't have a mention, but that PR doesn't appear to have an impact on userland - maybe a NEWS entry ?
@jrfnl jrfnl force-pushed the feature/php-8.4-upgrading-tweaks branch from efc0024 to 064ad61 Compare August 11, 2024 10:46
@nielsdos nielsdos merged commit cb8df21 into php:master Aug 11, 2024
2 checks passed
@nielsdos
Copy link
Member

Merged, thanks

@jrfnl jrfnl deleted the feature/php-8.4-upgrading-tweaks branch August 11, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants