Autotools: Simplify adding tidy cflags #15577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ext/tidy/config.m4
Outdated
| @@ -58,8 +58,10 @@ if test "$PHP_TIDY" != "no"; then | |||
| PHP_ADD_INCLUDE([$TIDY_INCDIR]) | |||
|
|
|||
| dnl Add -Wno-ignored-qualifiers as this is an issue upstream | |||
There was a problem hiding this comment.
Is this still a problem upstream? Unfortunately 1393834 that added this doesn't seem to reference anything...
There was a problem hiding this comment.
Yes, still happening with tidy-html5 versions before 5.7.20:
/usr/include/tidy/tidy.h:2095:13: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
2095 | TIDY_EXPORT const ctmbstr TIDY_CALL TidyLangWindowsName( const tidyLocaleMapItem *item );
| ^~~~~
/usr/include/tidy/tidy.h:2101:13: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
2101 | TIDY_EXPORT const ctmbstr TIDY_CALL TidyLangPosixName( const tidyLocaleMapItem *item );
| ^~~~~
|
Merging this soon. Looks ok and to simplify possible TIDY_CFLAGS variable usage in the future from the pkg-config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.