Fix GH-13988: Storing DOMElement consume 4 times more memory in PHP 8.1 than in PHP 8.0 #15593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
force-pushed
the
fix-13988
branch
2 times, most recently
from
f68eed1 to
64ae704
Compare
…P 8.1 than in PHP 8.0 We avoid creating backing storage by using the feature introduced in f78d5cf.
kocsismate
reviewed
Aug 27, 2024
| public function replace(string $token, string $newToken): bool {} | ||
| public function supports(string $token): bool {} | ||
| /** @virtual */ | ||
| public string $value; |
There was a problem hiding this comment.
why aren't the two properties listed before the methods as usual?
There was a problem hiding this comment.
The DOM spec also defines the class structure, and I just follow the same ordering that the spec uses. They tend to group things based on functionality similarities. Although idk either why value isn't on top here.
kocsismate
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We avoid creating backing storage by using the feature introduced in f78d5cf.
Also have to remove the default value because we don't have backing storage, otherwise we break engine constraints. This doesn't matter in practice because the default value is read anyway via the getter, so it was actually unused anyway...