Zend: support relative paths for extensions #159
Conversation
This would simplify greatly puppetization of Zend modules such as xdebug in heterogeneous environments. For example: zend_extension="/usr/lib/php5/20090626/xdebug.so" can become: zend_extension=xdebug.so
|
Looks like a false positive. I pulled again just in case and git 1.7.11.4 rebased like a charm. |
|
BTW, I didn't look into your branching model (not a PHP fan, sorry), but a backport of this feature in 5.3 (which I developed this for) and 5.4 would be most welcome. Any chance that might happen? Is there a procedure I can follow for that? |
| @@ -20,6 +20,7 @@ | |||
| /* $Id$ */ | |||
|
|
|||
| #include "zend_extensions.h" | |||
| #include "php.h" | |||
|
|
|||
There was a problem hiding this comment.
It's not a good idea make Zend engine rely on php
There was a problem hiding this comment.
php.h is used for DEFAULT_SLASH, IS_SLASH and INI_STR("extension_dir").
Do we have equivalents in the Zend world?
There was a problem hiding this comment.
that is one reason of why zend extension does not support relative path.
There was a problem hiding this comment.
OK. Could we consider an optional approach based on dlsym?
There was a problem hiding this comment.
yes, including php.h in Zend Engine files is definitely a no go. Same for using any symbols not originating in Zend Engine.
|
Hi, @travisbot is a bot indeed , and PHP's test on travis-ci.org didn't works that well. you could ignore that for now:) |
|
Comment on behalf of laruence at php.net: won't fix, it's trivial and fixing this will need over expensive costs |
|
EDIT: Found reasonable fix after posting. A little hacky, but it works. Still think this is a reasonable request, but not a blocker :) Not so trivial for config management tools as they are put in developer's hands. Hitting the same issue with chef. Throws a big red error that is confusing to new users on the first boot of any environment that is provisioning. System's integration tools are getting simpler and simpler to pass to developers, so I can't imagine my project will be the only one it affects. Anyone using xdebug with vagrant (and any config management tool that rightfully passes warnings forward) should see it flash up on the first boot |
|
https://bugs.php.net/bug.php?id=54564 |
This would simplify greatly puppetization of Zend modules such as xdebug
in heterogeneous environments.
For example:
zend_extension="/usr/lib/php5/20090626/xdebug.so"
can become:
zend_extension=xdebug.so