Fix ext/mysql test failed #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for spoting this, but the connect.inc was already include in skipif.inc. so, your fix is still mess, I can not merge it. I fixed by hand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ext/mysql/tests/mysql_query_load_data_openbasedir.phpt
skipif section:
connect.inc was include before skipif.inc. but if mysql wasn't enabled. connect will fatal
because of missing function: mysql_get_client_info(). then skipif section output nothing.
this makes this tests didn't skip.
This is 5.3 only, since the patch could not directly been merged to 5.4/master.
I will send another PR.