-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial ZendMM conversion of glob #17433
base: master
Are you sure you want to change the base?
Conversation
About the persistence, it should not be persistent so it counts against memory limit which is the main point in changing this. But you should of course check all the usage and make sure it is never user outside the request or re-used between request - it shouldn't but better to check. |
I'm also not sure about the glob limits (for malloc and others). It might be good to check if glibc have similar limits to see if they should be kept - doesn't need to be changed as part of this PR but would make sense to look into before switching to it on Linux as well. |
Removes the vendored OpenBSD reallocarray and changes libc memory management to ZendMM. Not sure if non-persistent is the right call, I think glob users use it then call globfree ASAP within a request, but it might be preferable to use persistent allocations.
03ccf37
to
9488a27
Compare
In the places glob is used:
...all instances of it call globfree in the same function, with the exception of the glob stream wrapper. |
Removes the vendored OpenBSD reallocarray and changes libc memory management to ZendMM.
Not sure if non-persistent is the right call, I think glob users use it then call globfree ASAP within a request, but it might be preferable to use persistent allocations.