Skip to content

Fix leak when creating cycle in hook #18917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix leak when creating cycle in hook #18917

wants to merge 1 commit into from
+28 −0

Conversation

iluuu1994
Copy link
Member

This is necessary because the VM frees operands with the nogc variants. We cannot just call gc_possible_root() because the object may no longer exist at that point.

Fixes GH-18907

@iluuu1994
Fix leak when creating cycle in hook
819064a 
This is necessary because the VM frees operands with the nogc variants. We
cannot just call gc_possible_root() because the object may no longer exist at
that point.

Fixes phpGH-18907
@iluuu1994 iluuu1994 requested a review from nielsdos June 22, 2025 22:10
@iluuu1994 iluuu1994 requested a review from dstogov as a code owner June 22, 2025 22:10
nielsdos
nielsdos approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see why this will work. A bit unfortunate that we also have to do refcount protection, but this may be the simplest solution.

@iluuu1994 iluuu1994 closed this in fe504d3 Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstogov dstogov dstogov approved these changes

@nielsdos nielsdos nielsdos approved these changes

Assignees
No one assigned
Labels
Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iluuu1994 @dstogov @nielsdos