Zend: Exception::__toString() no need to allocate the method name #19025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
exception-tostring-opt
branch
from
fd89943 to
d4238df
Compare
nielsdos
reviewed
Jul 3, 2025
|
Right I remember having to fix that compile issue before. The best way that works on all compilers is just assigning the fields rather than using an initializer. |
We can create the FCI/FCC pair ourself outside of the loop as the method getTraceAsString is final Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
Girgias
force-pushed
the
exception-tostring-opt
branch
from
db94226 to
f4a7ae7
Compare
|
Turns out we still need to do some scope fixes as we are calling the method multiple times. Not sure what the second loop going through the previous exceptions actually does tho. |
nielsdos
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can create the FCI/FCC pair ourself outside of the loop as the method getTraceAsString is final