Skip to content

Fix GH-18877: \Dom\HTMLDocument querySelectorAll selecting only the first when using ~ and :has #19180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: PHP-8.4
Choose a base branch
from

Conversation

nielsdos
Copy link
Member

Backports lexbor/lexbor@971faf1

cc @momala454
I'm a bit "scared" to backport such large patches, so perhaps this should land on master first and then be backported to 8.4 when no problems show up...

@nielsdos nielsdos changed the base branch from master to PHP-8.4 July 18, 2025 23:08
@Girgias
Copy link
Member

Girgias commented Jul 20, 2025

Definitely fine for master, and it's probably fine for 8.4 as well I'd imagine, or is there a way to compile ext/dom by using an external lexbor version?

@nielsdos
Copy link
Member Author

or is there a way to compile ext/dom by using an external lexbor version?

Fortunately not, as that would mean that I have to support even more configurations :P

@Girgias
Copy link
Member

Girgias commented Jul 20, 2025

ACK, then it probably makes sense to backport.
Not exactly sure what our policy is for fixes in bundled libraries however :/

@nielsdos
Copy link
Member Author

Not exactly sure what our policy is for fixes in bundled libraries however :/

I haven't heard of a policy regarding this. All I can say is that I've backported fixes to both ext/fileinfo and ext/pcre 🤷

@TimWolla
Copy link
Member

Even upgrading to new upstream releases with a reasonable release policy (e.g. just fixes and good test coverage) within a release PHP branch seems okay to me and even preferable to picking individual commits, because the latter means that PHP would have a version of the library that doesn't actually exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

\Dom\HTMLDocument querySelectorAll selecting only the first when using ~ and :has
3 participants