Throw ValueError when 1 is provided to the second argument of log()
#19370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Aug 5, 2025
ext/standard/math.c
Outdated
Comment on lines
670
to
675
| if (base == 1.0) { | ||
| RETURN_DOUBLE(ZEND_NAN); | ||
| zend_argument_value_error(2, "must not be 1"); | ||
| RETURN_THROWS(); | ||
| } | ||
|
|
||
| if (base <= 0.0) { |
There was a problem hiding this comment.
Might make sense to unify both conditions and messages?
There was a problem hiding this comment.
Given that values in ]0;1[ work, I'm not sure. I like having an accurate error message, however I'm not against having "must not be 1 or less than 0" if you prefer.
There was a problem hiding this comment.
I think having a combined message as you suggested is better.
But people might think that going straight to a ValueError is too harsh in which case we would need a warning... but this feels like it should be fine.
alexandre-daubois
force-pushed
the
log-base-1
branch
from
36f4140 to
755ddc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps with early error detection and explicit intent, instead of having a potential NaN propagating.