Fix GH-19397: mb_list_encodings() can cause crashes on shutdown #19405
+13
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The request shutdown does not necessarily hold the last reference, if there is still a CV that refers to the array.
youkidearitai
approved these changes
Aug 7, 2025
nikic
reviewed
Aug 7, 2025
ext/mbstring/mbstring.c
Outdated
| if (GC_DELREF(MBSTRG(all_encodings_list)) == 0) { | ||
| /* must be *array* destroy to remove from GC root buffer and free the hashtable itself */ | ||
| zend_array_destroy(MBSTRG(all_encodings_list)); | ||
| } |
There was a problem hiding this comment.
Wanted to avoid the immutability check, but sure
There was a problem hiding this comment.
In fact that's what I proposed initially #19397 (comment)
youkidearitai
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The request shutdown does not necessarily hold the last reference, if there is still a CV that refers to the array.