Fix build break when building with Google native client tool chain. #195
Conversation
The native client compiler defines the C macro __x86_64__, but the size of an unsigned int is only 4 bytes. This causes the compile to fail because the inline asm code compiled is for an 8 byte unsigned int. Add the correct defines to fix this. As detailed in: http://code.google.com/p/nativeclient/issues/detail?id=2255
* PHP-5.4: Support building PHP with the native client toolchain.
|
What about other instances - such as zend_multiply.h, zend_operators.h? |
|
There is no build break in these files as it falls through to the In this pull request I was specifically addressing the build breakage. On Sun, Sep 16, 2012 at 8:17 AM, Stanislav Malyshev <
|
|
@sjlangley Do you know why the fall through works in the other cases but not here? The code looks very similar. |
|
Because it falls through to C code, not assembler. On Sun, Sep 16, 2012 at 10:20 AM, nikic notifications@github.com wrote:
|
|
Comment on behalf of stas at php.net: merged |
4 participants
This is a small patch to ensure that the correct asm is built when cross compiling to native client. (https://developers.google.com/native-client/).
Description of the issue being corrected is here -> http://code.google.com/p/nativeclient/issues/detail?id=2255