Skip to content

Conversation

@arnaud-lb
Copy link
Member

@arnaud-lb arnaud-lb commented Oct 30, 2025

Possible fix for GH-20329.

  • In SERIALIZE_STR(), ensure that we update the right copy of the string. ptr is an interior pointer to script->mem, which is SHM or a temporary serialization of the script. buf is the copy of script->mem that will be written to the file cache.
  • Remove the IS_STR_CLASS_NAME_MAP_PTR flag

NB: I'm wondering if the if (script->corrupted) branch is useful, as we update flags in the same way in UNSERIALIZE_STR().

@arnaud-lb arnaud-lb changed the title Remove CE cache from non-interned file cache strings Fix GH-20329: Remove CE cache from non-interned file cache strings Oct 30, 2025
@arnaud-lb arnaud-lb marked this pull request as ready for review October 30, 2025 15:25
@arnaud-lb arnaud-lb requested a review from dstogov as a code owner October 30, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant