Fix GH-20329: Remove CE cache from non-interned file cache strings #20337
+6
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for GH-20329.
SERIALIZE_STR(), ensure that we update the right copy of the string.ptris an interior pointer toscript->mem, which is SHM or a temporary serialization of the script.bufis the copy ofscript->memthat will be written to the file cache.IS_STR_CLASS_NAME_MAP_PTRflagNB: I'm wondering if the
if (script->corrupted)branch is useful, as we update flags in the same way inUNSERIALIZE_STR().