Zend: reengineer how __debugInfo() magic method is handed #20549
+743
−377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
__debug-not-array-type-error
branch
from
ddeea0e to
06473b1
Compare
Girgias
force-pushed
the
__debug-not-array-type-error
branch
from
859a11e to
d0f39ef
Compare
The primary motivation is to get rid of the bailout by using a type error, but also properly abort the output when an exception is thrown or the deprecation notice is promoted to an exception. This is effectively an internal API change as extensions are no longer allowed to return NULL to fast path an empty array.
Girgias
force-pushed
the
__debug-not-array-type-error
branch
from
d0f39ef to
836fc12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary motivation is to get rid of the bailout by using a type error, but also properly abort the output when an exception is thrown or the deprecation notice is promoted to an exception.
This is effectively an internal API change as extensions are no longer allowed to return NULL to fast path an empty array.
As a NULL pointer return is now used to indicate an exception was thrown and we need to propagate this information around.
I heavily refactored
var_dump()anddebug_zval_dump()as they are quite similar by using common implementations written in CPS.