Skip to content

fix: null pointer dereference and memory leak #20829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
609bob wants to merge 1 commit into from
Closed

fix: null pointer dereference and memory leak #20829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions ext/dom/php_dom.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,9 +648,11 @@ static zend_object *dom_objects_store_clone_obj(zend_object *zobject) /* {{{ */
xmlNodePtr node = (xmlNodePtr)dom_object_get_node(intern);
if (node != NULL) {
php_dom_private_data *private_data = NULL;
bool private_data_created = false;
if (php_dom_follow_spec_intern(intern)) {
if (node->type == XML_DOCUMENT_NODE || node->type == XML_HTML_DOCUMENT_NODE) {
private_data = php_dom_private_data_create();
private_data_created = true;
} else {
private_data = php_dom_get_private_data(intern);
}
Expand All @@ -659,9 +661,13 @@ static zend_object *dom_objects_store_clone_obj(zend_object *zobject) /* {{{ */
xmlNodePtr cloned_node = dom_clone_node(php_dom_ns_mapper_from_private(private_data), node, node->doc, true);
if (cloned_node != NULL) {
dom_update_refcount_after_clone(intern, node, clone, cloned_node);
}
if (private_data != NULL) {
clone->document->private_data = php_dom_libxml_private_data_header(private_data);
if (private_data != NULL && clone->document != NULL) {
clone->document->private_data = php_dom_libxml_private_data_header(private_data);
}
} else {
if (private_data_created && private_data != NULL) {
php_dom_private_data_destroy(private_data);
}
}
}
}
Expand Down