-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mbstring use UTF-8 #22
Conversation
We are taking about the default (including hard coded one) php.ini settings in the internal list. What is the conclusion? I think changes are mostly good, except mbstring.encoding_translation should be "Off". I prefer substitution to none, since we don't have give attackers to clue what is going on. |
+1 In my humble opinion: this settings comes from Hiroshi Tokumaru's article: It will prevent some security issues which is caused by character encoding.
I agree @yohgaki 's opinion. |
In old days, some browsers couldn't handle char encoding right and there were some cases automatic encoding translation is useful. I think PHP shouldn't convert input encoding automatically, now a days. There is both pros and cons for translating invalid char to NULL or any other actual chars. When this setting is introduced, we agreed to set this to none. i.e. remove invalid parts of strings I prefer not to convert invalid chars to '?' which may have some meaning in certain string. Anyway, changes are already committed to master. |
Just to be sure I got this right: This only changes the comments in the php.ini example files, so the PHP defaults didn't actually change. Right? |
Most of all my suggest is php.ini sample want be new settings. Thank you for merging my request. |
Character encoding is UTF-8 used in mbstring recently. I want to change the default values from EUC-JP.