server-tests.php improvements #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tstarling
commented
Oct 29, 2012
tstarling
commented
- Fixed use of deprecated functions ereg(), split(), etc.
- Fixed notice due to _sendHTTP() declared return by reference but not returning anything.
- Fixed interpretation of EXPECTF, copying from run-tests.php
* Fixed use of deprecated functions ereg(), split(), etc. * Fixed notice due to _sendHTTP() declared return by reference but not returning anything. * Fixed interpretation of EXPECTF, copying from run-tests.php
|
merged. thanks |
php-pulls
pushed a commit
that referenced
this pull request
Oct 30, 2017
Not regarding the CGI section might even been seen as a bug, and since server-tests.php appears to broken, anway[1][2], we implement it for run-tests.php in the way as described[3] for server-tests.php, i.e. respective tests are skipped if no CGI executable is found. [1] <#222 (comment)> [2] <#1811 (comment)> [3] <https://qa.php.net/phpt_details.php#cgi_section>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.