Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bringing CSS up to this decade's standards. #231

Merged
merged 4 commits into from
Jul 22, 2013
Merged

Conversation

cviebrock
Copy link
Contributor

Here are some tweaks to the CSS styling for phpinfo(), since this really hasn't been touched in almost a decade:

  • color codes are shortened (e.g. #000000 is now #000)
  • table width is bigger and handled via CSS instead of HTML attributes
  • fix so that long INI entries don't make the layout super wide
  • bgcolor for "Additional Modules" wasn't set
  • the .vr class has been removed since I can't find any use of it in the entire source tree
  • fixed my email address

Signed-off-by: Colin Viebrock colin@viebrock.ca

Here are some tweaks to the phpinfo() styling, since this really hasn't
been touched in almost a decade:
- color codes are shortened
- table width is bigger and handled via CSS
- fix so that long INI entries don't make the layout super wide
- bgcolor for "Additional Modules" wasn't set
- fix my email address

Signed-off-by: Colin Viebrock <colin@viebrock.ca>
@cviebrock
Copy link
Contributor Author

It would appear that there was some end-of-line trailing whitespace cleanup as well.

@laruence
Copy link
Member

hey, in my chrome, after this patch, scroll bar shows up in the tds..

could you re-view this?

@cviebrock
Copy link
Contributor Author

That was the point: making the TDs scrollable if the content is long ... Rather than forcing the entire table (and page) to be wider than the screen.

  • Colin

On 2012-11-24, at 10:13 PM, Xinchen Hui notifications@github.com wrote:

hey, in my chrome, after this patch, scroll bar shows up in the tds..

could you re-view this?


Reply to this email directly or view it on GitHub.

@clamburger
Copy link

I think laurence is referring to the vertical scroll bars that appear in every cell, in addition to the horizontal scroll bars that only appear if the content is too long.

Useless scroll bars

Replacing overflow-y: scroll with overflow-x: auto keeps the horizontal scroll bars where needed and removes the vertical scroll bars.

@cviebrock
Copy link
Contributor Author

Thanks @clamburger ... I've changed the overflow as suggested. And added a few other minor tweaks.

I've also noticed that the Zend Logo is probably out-of-date, so I've asked the folks there if there is a more recent one to use.

@lstrojny
Copy link
Contributor

@laruence, @cviebrock what’s the status?

@cviebrock
Copy link
Contributor Author

I'm done making changes (unless there are bug fixes). It tests well in all browsers I have access to (Safari, FF, Chrome). I suppose someone should check in MSIE.

@dsp
Copy link
Member

dsp commented Mar 19, 2013

whats the status of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants