Typofixes #332
Closed
Typofixes #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, thanks for taking the time to fix those little things. Any chance to rebase the pull request so it is opened against PHP-5.5 branch? I would love to merge this into 5.5. Thanks |
ghost
assigned 
|
Ehh. I am not a big git expert... I tried... I created a new branch typofixes-PHP-5.5 i switched to my orig typofixes branch I typed the git rebase typofixes-55. It seemed to be working, but push isnt copying the changes back to github. I dont understand... Can you help me? vlajos@asusl:~/github/php-src$ git branch
master
typofixes
* typofixes-PHP-5.5
vlajos@asusl:~/github/php-src$ git log --all|head -30
commit 70fd113af70a6bfc7bcd8e3085170cdab25c7799
Author: Veres Lajos
Date: Tue Apr 23 11:26:46 2013 +0100
typofixes (occurrence 2)
commit fde24e1cfd94cc71fc60d6be58318f6818fbe5b0
Author: Veres Lajos
Date: Tue Apr 23 11:20:05 2013 +0100
typofixes (accommodate)
...
vlajos@asusl:~/github/php-src$ git push origin typofixes-PHP-5.5
Everything up-to-date
vlajos@asusl:~/github/php-src$
|
Closed
|
Recreated on a whole new branch: #341 I think it is okey... but not so sure. |
|
Comment on behalf of stas at php.net: duplicate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly in non "living" code. Anyway a review is needed...