Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for bug 60596, code clean up #4

Closed
wants to merge 10,000 commits into from
Closed

Fix for bug 60596, code clean up #4

wants to merge 10,000 commits into from

Conversation

ircmaxell
Copy link
Contributor

Cleaning a superfluous if statement from spl_offset_convert_to_long.

https://bugs.php.net/bug.php?id=60596

johannes and others added 30 commits November 2, 2011 15:45
- Fix bug #60155 (pdo_mysql.default_socket ignored).
3df26f1 
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318696 c90b9560-bf6c-de11-be94-00142212c4b1
fix calling user close func when it isn't open
9c0365d 
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318698 c90b9560-bf6c-de11-be94-00142212c4b1
Add a middleman which can intercept the calls and can reroute them
f3d4aa3 
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318699 c90b9560-bf6c-de11-be94-00142212c4b1
initialize variable and fix segfaulting tests
6c22598 
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318705 c90b9560-bf6c-de11-be94-00142212c4b1
fix folding, ws and cs
4aa3fcf 
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318706 c90b9560-bf6c-de11-be94-00142212c4b1
adding memory check for FreeBSD also, TODO: refactor the free memory …
42ce063 
…check into a function in an include file

git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318708 c90b9560-bf6c-de11-be94-00142212c4b1
Fix bug #60169 Conjunction of ternary and list crashes PHP
922f48e 
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318716 c90b9560-bf6c-de11-be94-00142212c4b1
xfail, not fix yet
25bdf95 
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318717 c90b9560-bf6c-de11-be94-00142212c4b1
Fixed bug #60206 (possible integer overflow in content_length)
1da566b 
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318718 c90b9560-bf6c-de11-be94-00142212c4b1
use jmp_addr only when it's initialized
a9bc2ce 
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318723 c90b9560-bf6c-de11-be94-00142212c4b1
- Fixed bug #60179 (php_flag and php_value does not work properly)
14c4db2 
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318743 c90b9560-bf6c-de11-be94-00142212c4b1
Redid the fix for #60192 with suggestions by Pierre and Kalle
9f3a6b6 
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318744 c90b9560-bf6c-de11-be94-00142212c4b1
Improving test to reflect latest API changes
33f346d 
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318750 c90b9560-bf6c-de11-be94-00142212c4b1
Replace custom "stress_test" setting with generic SKIP_SLOW_TESTS
a5b0b19 
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318759 c90b9560-bf6c-de11-be94-00142212c4b1
Bump OCI8 version to 1.4.7 stable in preparation for PHP 5.3.9
ba04b0c 
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318760 c90b9560-bf6c-de11-be94-00142212c4b1
Fixed Bug #60217 (Requiring the same method from different traits)
4e95403 
- also added test to check for inconsistent abstract method definitions, they need to be compatible


git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318793 c90b9560-bf6c-de11-be94-00142212c4b1
Fixed inconsistent whitespace.
e761d76 
# Belongs to svn rev. 318793.


git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318794 c90b9560-bf6c-de11-be94-00142212c4b1
added japanese encoding to maintain compatibility with PHP 5.3.
f85a858 
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318802 c90b9560-bf6c-de11-be94-00142212c4b1
the mandatory __construct() for SPL classes was reverted in r318566
c03a9b6 
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318808 c90b9560-bf6c-de11-be94-00142212c4b1
fixed bug #60227: header() cannot detect the multi-line header with CR.
81db8ec 
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318820 c90b9560-bf6c-de11-be94-00142212c4b1
- Added class member access on instantiation (e.g. (new foo)->bar()) …
90fd3e1 
…support

git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318823 c90b9560-bf6c-de11-be94-00142212c4b1
Improve OCI8 NLS env creation error messages (#58925)
1a92acc 
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318888 c90b9560-bf6c-de11-be94-00142212c4b1
Fixed bug #54084 (token_get_all with regards to __halt_compiler is no…
51ab6d1 
…t binary safe)

git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318902 c90b9560-bf6c-de11-be94-00142212c4b1
Fix tests
7cb327b 
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318904 c90b9560-bf6c-de11-be94-00142212c4b1
Fixed bug #60104 (Segmentation Fault in pdo_sqlite when using sqliteC…
cc36a51 
…reateFunction())

git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318907 c90b9560-bf6c-de11-be94-00142212c4b1
bail out if reading HTTP headers failed
d2207ff 
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318911 c90b9560-bf6c-de11-be94-00142212c4b1
fix bug #55475 - implement is_a BC solution
cb9a33f 
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318938 c90b9560-bf6c-de11-be94-00142212c4b1
Add tests for unsupported types
b337972 
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318939 c90b9560-bf6c-de11-be94-00142212c4b1
- Initialize BG(serialize_lock) to make valgrind happy
0f7c8e6 
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318962 c90b9560-bf6c-de11-be94-00142212c4b1
- Make valgrind happy with session_decode_error2.phpt
8102861 
git-svn-id: http://svn.php.net/repository/php/php-src/trunk@318965 c90b9560-bf6c-de11-be94-00142212c4b1
bwoebi pushed a commit to bwoebi/php-src that referenced this pull request Dec 10, 2021
@JordanRL
Merge pull request php#4 from bwoebi/operator-overloads
52f3f09 
Use operator keyword instead of magic methods
@derickr derickr mentioned this pull request Jan 3, 2022
Closed
This was referenced Feb 20, 2022
Closed
Open
@unix-world unix-world mentioned this pull request Mar 4, 2022
Closed
@mokraemer mokraemer mentioned this pull request Mar 10, 2022
Closed
@0xhacking 0xhacking mentioned this pull request Mar 17, 2022
Closed
@ffang-imvu ffang-imvu mentioned this pull request Jun 15, 2022
Closed
@ErikRoelofs ErikRoelofs mentioned this pull request Jun 23, 2022
Closed
@triplesixman triplesixman mentioned this pull request Jun 30, 2022
Closed
@gregherrell gregherrell mentioned this pull request Aug 17, 2022
Open
@vityank vityank mentioned this pull request Aug 22, 2022
Open
@pfrappe pfrappe mentioned this pull request Jan 27, 2023
Open
@stkeke stkeke mentioned this pull request Mar 15, 2023
Closed
@kinghuaq kinghuaq mentioned this pull request May 12, 2023
Closed
@slawomir-pryczek slawomir-pryczek mentioned this pull request May 15, 2023
Closed
@aswingit aswingit mentioned this pull request May 23, 2023
Closed
@sysadminpower2019 sysadminpower2019 mentioned this pull request Jun 11, 2023
Closed
@dunglas dunglas mentioned this pull request Sep 17, 2023
Closed
@gadj0dil0 gadj0dil0 mentioned this pull request Jan 30, 2024
Closed
@jcencekibm jcencekibm mentioned this pull request Apr 1, 2024
Closed
@divinity76 divinity76 mentioned this pull request Apr 15, 2024
Open
@alex0107 alex0107 mentioned this pull request May 18, 2024
Closed
@dlsrc dlsrc mentioned this pull request Aug 5, 2024
Closed
devnexen added a commit to devnexen/php-src that referenced this pull request Oct 12, 2024
@devnexen
ext/gmp: gmp_pow fix FPE with large values.
bf0c2a8 
even without sanitizers, it is reproducible but with the following

```
<?php
$g = gmp_init(256);
var_dump(gmp_pow($g, PHP_INT_MAX));
```

we get this

```
AddressSanitizer:DEADLYSIGNAL
=================================================================
==286922==ERROR: AddressSanitizer: FPE on unknown address 0x03e8000460ca (pc 0x7faf6c69de5c bp 0x400000000000004 sp 0x7ffe9843c740 T0)
    #0 0x7faf6c69de5c in __pthread_kill_implementation nptl/pthread_kill.c:44
    #1 0x7faf6c649c81 in __GI_raise ../sysdeps/posix/raise.c:26
    php#2 0x7faf6db9386c in __gmp_exception (/lib/x86_64-linux-gnu/libgmp.so.10+0xd86c) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38)
    php#3 0x7faf6db938d3 in __gmp_overflow_in_mpz (/lib/x86_64-linux-gnu/libgmp.so.10+0xd8d3) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38)
    php#4 0x7faf6dbac95c in __gmpz_realloc (/lib/x86_64-linux-gnu/libgmp.so.10+0x2695c) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38)
    php#5 0x7faf6dba9038 in __gmpz_n_pow_ui (/lib/x86_64-linux-gnu/libgmp.so.10+0x23038) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38)
    php#6 0x5565ae1ccd9f in zif_gmp_pow /home/dcarlier/Contribs/php-src/ext/gmp/gmp.c:1286
    php#7 0x5565aee96ea9 in ZEND_DO_ICALL_SPEC_RETVAL_USED_HANDLER /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:1312
    php#8 0x5565af144320 in execute_ex /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:56075
    php#9 0x5565af160f07 in zend_execute /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:60439
    php#10 0x5565aed6fafe in zend_execute_scripts /home/dcarlier/Contribs/php-src/Zend/zend.c:1842
    php#11 0x5565aeae70a8 in php_execute_script /home/dcarlier/Contribs/php-src/main/main.c:2578
    php#12 0x5565af532f4e in do_cli /home/dcarlier/Contribs/php-src/sapi/cli/php_cli.c:964
    php#13 0x5565af535877 in main /home/dcarlier/Contribs/php-src/sapi/cli/php_cli.c:1334
    php#14 0x7faf6c633d67 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
    php#15 0x7faf6c633e24 in __libc_start_main_impl ../csu/libc-start.c:360
    php#16 0x5565adc04040 in _start (/home/dcarlier/Contribs/php-src/sapi/cli/php+0x2604040) (BuildId: 949049955bdf8b7197390b1978a1dfc3ef6fdf38)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: FPE nptl/pthread_kill.c:44 in __pthread_kill_implementation
==286922==ABORTING
```
devnexen added a commit that referenced this pull request Oct 13, 2024
@devnexen
ext/gmp: gmp_pow fix FPE with large values.
d70b781 
even without sanitizers, it is reproducible but with the following

```
<?php
$g = gmp_init(256);
var_dump(gmp_pow($g, PHP_INT_MAX));
```

we get this

```
AddressSanitizer:DEADLYSIGNAL
=================================================================
==286922==ERROR: AddressSanitizer: FPE on unknown address 0x03e8000460ca (pc 0x7faf6c69de5c bp 0x400000000000004 sp 0x7ffe9843c740 T0)
    #0 0x7faf6c69de5c in __pthread_kill_implementation nptl/pthread_kill.c:44
    #1 0x7faf6c649c81 in __GI_raise ../sysdeps/posix/raise.c:26
    #2 0x7faf6db9386c in __gmp_exception (/lib/x86_64-linux-gnu/libgmp.so.10+0xd86c) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38)
    #3 0x7faf6db938d3 in __gmp_overflow_in_mpz (/lib/x86_64-linux-gnu/libgmp.so.10+0xd8d3) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38)
    #4 0x7faf6dbac95c in __gmpz_realloc (/lib/x86_64-linux-gnu/libgmp.so.10+0x2695c) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38)
    #5 0x7faf6dba9038 in __gmpz_n_pow_ui (/lib/x86_64-linux-gnu/libgmp.so.10+0x23038) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38)
    #6 0x5565ae1ccd9f in zif_gmp_pow /home/dcarlier/Contribs/php-src/ext/gmp/gmp.c:1286
    #7 0x5565aee96ea9 in ZEND_DO_ICALL_SPEC_RETVAL_USED_HANDLER /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:1312
    #8 0x5565af144320 in execute_ex /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:56075
    #9 0x5565af160f07 in zend_execute /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:60439
    #10 0x5565aed6fafe in zend_execute_scripts /home/dcarlier/Contribs/php-src/Zend/zend.c:1842
    #11 0x5565aeae70a8 in php_execute_script /home/dcarlier/Contribs/php-src/main/main.c:2578
    #12 0x5565af532f4e in do_cli /home/dcarlier/Contribs/php-src/sapi/cli/php_cli.c:964
    #13 0x5565af535877 in main /home/dcarlier/Contribs/php-src/sapi/cli/php_cli.c:1334
    #14 0x7faf6c633d67 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
    #15 0x7faf6c633e24 in __libc_start_main_impl ../csu/libc-start.c:360
    #16 0x5565adc04040 in _start (/home/dcarlier/Contribs/php-src/sapi/cli/php+0x2604040) (BuildId: 949049955bdf8b7197390b1978a1dfc3ef6fdf38)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: FPE nptl/pthread_kill.c:44 in __pthread_kill_implementation
==286922==ABORTING
```
devnexen added a commit to devnexen/php-src that referenced this pull request Oct 17, 2024
@devnexen
ext/gmp: gmp_pow fix FPE with large values.
6339668 
even without sanitizers, it is reproducible but with the following

```
<?php
$g = gmp_init(256);
var_dump(gmp_pow($g, PHP_INT_MAX));
```

we get this

```
AddressSanitizer:DEADLYSIGNAL
=================================================================
==286922==ERROR: AddressSanitizer: FPE on unknown address 0x03e8000460ca (pc 0x7faf6c69de5c bp 0x400000000000004 sp 0x7ffe9843c740 T0)
    #0 0x7faf6c69de5c in __pthread_kill_implementation nptl/pthread_kill.c:44
    #1 0x7faf6c649c81 in __GI_raise ../sysdeps/posix/raise.c:26
    php#2 0x7faf6db9386c in __gmp_exception (/lib/x86_64-linux-gnu/libgmp.so.10+0xd86c) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38)
    php#3 0x7faf6db938d3 in __gmp_overflow_in_mpz (/lib/x86_64-linux-gnu/libgmp.so.10+0xd8d3) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38)
    php#4 0x7faf6dbac95c in __gmpz_realloc (/lib/x86_64-linux-gnu/libgmp.so.10+0x2695c) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38)
    php#5 0x7faf6dba9038 in __gmpz_n_pow_ui (/lib/x86_64-linux-gnu/libgmp.so.10+0x23038) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38)
    php#6 0x5565ae1ccd9f in zif_gmp_pow /home/dcarlier/Contribs/php-src/ext/gmp/gmp.c:1286
    php#7 0x5565aee96ea9 in ZEND_DO_ICALL_SPEC_RETVAL_USED_HANDLER /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:1312
    php#8 0x5565af144320 in execute_ex /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:56075
    php#9 0x5565af160f07 in zend_execute /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:60439
    php#10 0x5565aed6fafe in zend_execute_scripts /home/dcarlier/Contribs/php-src/Zend/zend.c:1842
    php#11 0x5565aeae70a8 in php_execute_script /home/dcarlier/Contribs/php-src/main/main.c:2578
    php#12 0x5565af532f4e in do_cli /home/dcarlier/Contribs/php-src/sapi/cli/php_cli.c:964
    php#13 0x5565af535877 in main /home/dcarlier/Contribs/php-src/sapi/cli/php_cli.c:1334
    php#14 0x7faf6c633d67 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
    php#15 0x7faf6c633e24 in __libc_start_main_impl ../csu/libc-start.c:360
    php#16 0x5565adc04040 in _start (/home/dcarlier/Contribs/php-src/sapi/cli/php+0x2604040) (BuildId: 949049955bdf8b7197390b1978a1dfc3ef6fdf38)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: FPE nptl/pthread_kill.c:44 in __pthread_kill_implementation
==286922==ABORTING
```
devnexen added a commit to devnexen/php-src that referenced this pull request Oct 21, 2024
@devnexen
ext/gmp: gmp_pow fix FPE with large values.
2ffc679 
even without sanitizers, it is reproducible but with the following

```
<?php
$g = gmp_init(256);
var_dump(gmp_pow($g, PHP_INT_MAX));
```

we get this

```
AddressSanitizer:DEADLYSIGNAL
=================================================================
==286922==ERROR: AddressSanitizer: FPE on unknown address 0x03e8000460ca (pc 0x7faf6c69de5c bp 0x400000000000004 sp 0x7ffe9843c740 T0)
    #0 0x7faf6c69de5c in __pthread_kill_implementation nptl/pthread_kill.c:44
    #1 0x7faf6c649c81 in __GI_raise ../sysdeps/posix/raise.c:26
    php#2 0x7faf6db9386c in __gmp_exception (/lib/x86_64-linux-gnu/libgmp.so.10+0xd86c) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38)
    php#3 0x7faf6db938d3 in __gmp_overflow_in_mpz (/lib/x86_64-linux-gnu/libgmp.so.10+0xd8d3) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38)
    php#4 0x7faf6dbac95c in __gmpz_realloc (/lib/x86_64-linux-gnu/libgmp.so.10+0x2695c) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38)
    php#5 0x7faf6dba9038 in __gmpz_n_pow_ui (/lib/x86_64-linux-gnu/libgmp.so.10+0x23038) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38)
    php#6 0x5565ae1ccd9f in zif_gmp_pow /home/dcarlier/Contribs/php-src/ext/gmp/gmp.c:1286
    php#7 0x5565aee96ea9 in ZEND_DO_ICALL_SPEC_RETVAL_USED_HANDLER /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:1312
    php#8 0x5565af144320 in execute_ex /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:56075
    php#9 0x5565af160f07 in zend_execute /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:60439
    php#10 0x5565aed6fafe in zend_execute_scripts /home/dcarlier/Contribs/php-src/Zend/zend.c:1842
    php#11 0x5565aeae70a8 in php_execute_script /home/dcarlier/Contribs/php-src/main/main.c:2578
    php#12 0x5565af532f4e in do_cli /home/dcarlier/Contribs/php-src/sapi/cli/php_cli.c:964
    php#13 0x5565af535877 in main /home/dcarlier/Contribs/php-src/sapi/cli/php_cli.c:1334
    php#14 0x7faf6c633d67 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
    php#15 0x7faf6c633e24 in __libc_start_main_impl ../csu/libc-start.c:360
    php#16 0x5565adc04040 in _start (/home/dcarlier/Contribs/php-src/sapi/cli/php+0x2604040) (BuildId: 949049955bdf8b7197390b1978a1dfc3ef6fdf38)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: FPE nptl/pthread_kill.c:44 in __pthread_kill_implementation
==286922==ABORTING
```
devnexen added a commit to devnexen/php-src that referenced this pull request Oct 24, 2024
@devnexen
ext/gmp: gmp_pow fix FPE with large values.
0c04ae6 
even without sanitizers, it is reproducible but with the following

```
<?php
$g = gmp_init(256);
var_dump(gmp_pow($g, PHP_INT_MAX));
```

we get this

```
AddressSanitizer:DEADLYSIGNAL
=================================================================
==286922==ERROR: AddressSanitizer: FPE on unknown address 0x03e8000460ca (pc 0x7faf6c69de5c bp 0x400000000000004 sp 0x7ffe9843c740 T0)
    #0 0x7faf6c69de5c in __pthread_kill_implementation nptl/pthread_kill.c:44
    #1 0x7faf6c649c81 in __GI_raise ../sysdeps/posix/raise.c:26
    php#2 0x7faf6db9386c in __gmp_exception (/lib/x86_64-linux-gnu/libgmp.so.10+0xd86c) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38)
    php#3 0x7faf6db938d3 in __gmp_overflow_in_mpz (/lib/x86_64-linux-gnu/libgmp.so.10+0xd8d3) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38)
    php#4 0x7faf6dbac95c in __gmpz_realloc (/lib/x86_64-linux-gnu/libgmp.so.10+0x2695c) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38)
    php#5 0x7faf6dba9038 in __gmpz_n_pow_ui (/lib/x86_64-linux-gnu/libgmp.so.10+0x23038) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38)
    php#6 0x5565ae1ccd9f in zif_gmp_pow /home/dcarlier/Contribs/php-src/ext/gmp/gmp.c:1286
    php#7 0x5565aee96ea9 in ZEND_DO_ICALL_SPEC_RETVAL_USED_HANDLER /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:1312
    php#8 0x5565af144320 in execute_ex /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:56075
    php#9 0x5565af160f07 in zend_execute /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:60439
    php#10 0x5565aed6fafe in zend_execute_scripts /home/dcarlier/Contribs/php-src/Zend/zend.c:1842
    php#11 0x5565aeae70a8 in php_execute_script /home/dcarlier/Contribs/php-src/main/main.c:2578
    php#12 0x5565af532f4e in do_cli /home/dcarlier/Contribs/php-src/sapi/cli/php_cli.c:964
    php#13 0x5565af535877 in main /home/dcarlier/Contribs/php-src/sapi/cli/php_cli.c:1334
    php#14 0x7faf6c633d67 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
    php#15 0x7faf6c633e24 in __libc_start_main_impl ../csu/libc-start.c:360
    php#16 0x5565adc04040 in _start (/home/dcarlier/Contribs/php-src/sapi/cli/php+0x2604040) (BuildId: 949049955bdf8b7197390b1978a1dfc3ef6fdf38)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: FPE nptl/pthread_kill.c:44 in __pthread_kill_implementation
==286922==ABORTING
```
devnexen added a commit that referenced this pull request Oct 25, 2024
@devnexen
ext/gmp: gmp_pow fix FPE with large values.
e0a0e21 
even without sanitizers, it is reproducible but with the following

```
<?php
$g = gmp_init(256);
var_dump(gmp_pow($g, PHP_INT_MAX));
```

we get this

```
AddressSanitizer:DEADLYSIGNAL
=================================================================
==286922==ERROR: AddressSanitizer: FPE on unknown address 0x03e8000460ca (pc 0x7faf6c69de5c bp 0x400000000000004 sp 0x7ffe9843c740 T0)
    #0 0x7faf6c69de5c in __pthread_kill_implementation nptl/pthread_kill.c:44
    #1 0x7faf6c649c81 in __GI_raise ../sysdeps/posix/raise.c:26
    #2 0x7faf6db9386c in __gmp_exception (/lib/x86_64-linux-gnu/libgmp.so.10+0xd86c) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38)
    #3 0x7faf6db938d3 in __gmp_overflow_in_mpz (/lib/x86_64-linux-gnu/libgmp.so.10+0xd8d3) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38)
    #4 0x7faf6dbac95c in __gmpz_realloc (/lib/x86_64-linux-gnu/libgmp.so.10+0x2695c) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38)
    #5 0x7faf6dba9038 in __gmpz_n_pow_ui (/lib/x86_64-linux-gnu/libgmp.so.10+0x23038) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38)
    #6 0x5565ae1ccd9f in zif_gmp_pow /home/dcarlier/Contribs/php-src/ext/gmp/gmp.c:1286
    #7 0x5565aee96ea9 in ZEND_DO_ICALL_SPEC_RETVAL_USED_HANDLER /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:1312
    #8 0x5565af144320 in execute_ex /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:56075
    #9 0x5565af160f07 in zend_execute /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:60439
    #10 0x5565aed6fafe in zend_execute_scripts /home/dcarlier/Contribs/php-src/Zend/zend.c:1842
    #11 0x5565aeae70a8 in php_execute_script /home/dcarlier/Contribs/php-src/main/main.c:2578
    #12 0x5565af532f4e in do_cli /home/dcarlier/Contribs/php-src/sapi/cli/php_cli.c:964
    #13 0x5565af535877 in main /home/dcarlier/Contribs/php-src/sapi/cli/php_cli.c:1334
    #14 0x7faf6c633d67 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
    #15 0x7faf6c633e24 in __libc_start_main_impl ../csu/libc-start.c:360
    #16 0x5565adc04040 in _start (/home/dcarlier/Contribs/php-src/sapi/cli/php+0x2604040) (BuildId: 949049955bdf8b7197390b1978a1dfc3ef6fdf38)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: FPE nptl/pthread_kill.c:44 in __pthread_kill_implementation
==286922==ABORTING
```

close GH-16384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ircmaxell @php-pulls @dsp @jakoch