Parameter skipping in function calls

[smalyshev]

See: https://wiki.php.net/rfc/skipparams

[nikic]

Several issues here:

• In the else case the code just continues without incrementing i, type_spec or fetching the respective va_arg(s)
• In the if case arg is set to a stack value which is a pointer to yet another stack value and both of those are in the if branch, so they won't exist after it is left.
• I get a warning for the ={0} initialization here. Maybe INIT_PZVAL instead?

Another consideration: Can it happen that the NULL zval create here will be modified in the arg_impl to some other type (that requires freeing?)

[Synchro]

(I''m not sure where this should be discussed)
Why do you want to introduce the 'default' keyword for this? Why not just be able to leave out the param altogether? Given:

function myfunc($p1, $p2 = 2, $p3 = 3) {};

you would normally be happy to call that like this:

myfunc('abc');

so I think this:

myfunc('abc', , 1);

is more concise and more readable than:

myfunc('abc', default, 1);

as it's far less likely to be confused with:

myfunc('abc', $default, 1);

[fruitl00p]

Stas,

After a long period of silence (last message around january 2013) on @Internals regarding this RFC, is there any chance this can be resurrected into existence? And by resurrecting i do hope the original ("default") way of utilizing this.

Thanks!

[joshtronic]

👍

[datibbaw]

I would expect func_get_args() to include the default value of arguments for which default was passed, e.g.:

function test($a = 1, $b = 2, $c = 3)
{
    var_dump(func_get_args());
}

test(20, default, 30); // [20, 2, 30]

[smalyshev]

@fruitl00p I think it can be revived, but it needs to be reconciled with phpng changes, so it'll take some time and I'd need to find that time to do the necessary change. I hope I will be able too soon.

[fruitl00p]

@smalyshev Thanks for the quick update. I have a vague idea how busy you are, no worries. Just don't want this to be lost in the anals of history ;)

Thanks again for the great work! (if only i had some C knowledge to be able to contribute)

[smalyshev]

Replaced by #981