EmptyIterator now implements Countable; fixes bug 60577 #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Queued for 5.4.21. |
|
I appreciate getting this looked at. However, my guess it should go into PHP 5.NEXT (such as 5.6). It's not truly a bug, just more of a misunderstanding that can be rectified later on. |
|
reverted. apply it to master if you will. |
|
@dsp I don't have karma for this stuff (just docs). Could you merge it into master or alternatively reopen the PR so that someone else can look at it? Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.php.net/bug.php?id=60577
This a feature request, not a bug. It seemed a logical change given that many iterators do implement
Countable.