Fix #72941: Modifying bucket->data by-ref has no effect any longer #6096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To match the PHP 5 behavior, we have to explicitly cater to `data` being a reference.
nikic
reviewed
Sep 8, 2020
nikic
reviewed
Sep 8, 2020
nikic
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match the PHP 5 behavior, we have to explicitly cater to
databeing a reference.
Given that this regression has been introduced in PHP 7.0.0, that the bug report didn't get much traction, and that using references here might not be the best idea anyway, I'm fine with treating the ticket as doc issue.