Rename XmlParser to XMLParser for consistency with XMLWriter/XMLReader

[Girgias]

@sgolemon @carusogabriel as RMs for PHP 8

[carusogabriel]

Hm, this is a tricky one. While I agree, today is GA day. Merging it into 8.0.1 is a BC-break with 8.0.0, and merging it into 8.0.0 is a BC-break with RC5, which is a problem because RC5 and GA should match.

I'll deffer this decision to Sara :)

[Girgias]

Well it's technically not BC as Class names as case insensitive in PHP... so not sure if it really matters in the end.

[carusogabriel]

It does, unfortunately 😕

Sniffers and Static Analyzers, for example, they would complain that you are using/importing XMLParser with the wrong case.

[GinoPane]

But XmlParser is a correct camel-cased name. It would be better to rename XMLWriter/XMLReader to XmlWriter/XmlReader instead

[claudepache]

But XmlParser is a correct camel-cased name. It would be better to rename XMLWriter/XMLReader to XmlWriter/XmlReader instead

It is good to look at precedents. In general, both conventions are in use (JsonException vs.DOMException). But in the case of XML, the pattern is clear:

LibXMLError
SimpleXMLElement
SimpleXMLIterator
XmlParser // <-- the outsider, just introduced in 8.0
XMLReader
XMLWriter

Note also:

XSLTProcessor

and:

DOMException
DOMImplementation
DOMNode
DOMNameSpaceNode
DOMDocumentFragment
DOMDocument
DOMNodeList
DOMNamedNodeMap
DOMCharacterData
DOMAttr
DOMElement
DOMText
DOMComment
DOMCdataSection
DOMDocumentType
DOMNotation
DOMEntity
DOMEntityReference
DOMProcessingInstruction
DOMXPath

[GinoPane]

But XmlParser is a correct camel-cased name. It would be better to rename XMLWriter/XMLReader to XmlWriter/XmlReader instead

It is good to look at precedents. In general, both conventions are in use (JsonException vs.DOMException). But in the case of XML, the pattern is clear:

LibXMLError
SimpleXMLElement
SimpleXMLIterator
XmlParser // <-- the outsider, just introduced in 8.0
XMLReader
XMLWriter

Note also:

XSLTProcessor

and:

DOMException
DOMImplementation
DOMNode
DOMNameSpaceNode
DOMDocumentFragment
DOMDocument
DOMNodeList
DOMNamedNodeMap
DOMCharacterData
DOMAttr
DOMElement
DOMText
DOMComment
DOMCdataSection
DOMDocumentType
DOMNotation
DOMEntity
DOMEntityReference
DOMProcessingInstruction
DOMXPath

Yes, I understand, it is true in terms of what is widely used in the current codebase. But if we speak about camel-case in general, all those accepted names turn to be not really correct. It does not mean we should fix them of course

[nikic]

Seems worthwhile to fix, given how consistently the XML capitalization is used right now.

I think this is okay for 8.0.1 as class names are case-insensitive, so at worst this should affect some code style checking.

[Girgias]

Merged as a55402d