Skip to content

JIT/AArch64: Use 'tbnz/tbz' to check the signedness #7123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2021
Merged

JIT/AArch64: Use 'tbnz/tbz' to check the signedness #7123

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4e68a9
JIT/AArch64: Use 'tbnz/tbz' to check the signedness
shqking Jun 8, 2021
ceb1613
Merge branch 'master' into use-tbnz
shqking Jun 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions ext/opcache/jit/zend_jit_arm64.dasc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1801,8 +1801,7 @@ static int zend_jit_exception_handler_stub(dasm_State **Dst)
| EXT_CALL handler, REG0
| ldp FP, RX, T2 // retore FP and IP
| ldp x29, x30, [sp], # NR_SPAD // stack alignment
| tst RETVALw, RETVALw
| blt >1
| tbnz RETVALw, #31, >1
| mov RETVALw, #1 // ZEND_VM_ENTER
|1:
| ret
Expand Down Expand Up @@ -2283,8 +2282,7 @@ static int zend_jit_hybrid_hot_trace_stub(dasm_State **Dst)
| mov FCARG1x, FP
| GET_IP FCARG2x
| EXT_CALL zend_jit_trace_hot_root, REG0
| cmp RETVALw, wzr // Result is < 0 on failure.
| blt >1
| tbnz RETVALw, #31, >1 // Result is < 0 on failure.
| MEM_LOAD_64_ZTS ldr, FP, executor_globals, current_execute_data, REG0
| LOAD_IP
| JMP_IP TMP1
Expand Down Expand Up @@ -8355,10 +8353,9 @@ static int zend_jit_push_call_frame(dasm_State **Dst, const zend_op *opline, con
| LOAD_32BIT_VAL TMP1w, ZEND_CALL_HAS_THIS
| str TMP1w, EX:RX->This.u1.type_info
} else {
| LOAD_32BIT_VAL TMP1w, ZEND_CALL_HAS_THIS
| ldr TMP2w, EX:RX->This.u1.type_info
| orr TMP2w, TMP2w, TMP1w
| str TMP2w, EX:RX->This.u1.type_info
| ldr TMP1w, EX:RX->This.u1.type_info
| BW_OP_32_WITH_CONST orr, TMP1w, TMP1w, ZEND_CALL_HAS_THIS, TMP2w
| str TMP1w, EX:RX->This.u1.type_info
}
} else {
if (opline->op1_type == IS_CV) {
Expand All @@ -8381,9 +8378,7 @@ static int zend_jit_push_call_frame(dasm_State **Dst, const zend_op *opline, con
} else {
if (opline->op2_type == IS_CV) {
| // GC_ADDREF(closure);
| ldr TMP1w, [REG0]
| add TMP1w, TMP1w, #1
| str TMP1w, [REG0]
| GC_ADDREF REG0, TMP1w
}
| // object_or_called_scope = closure->called_scope;
| ldr REG1, [REG0, #offsetof(zend_closure, called_scope)]
Expand Down