Skip to content

Fix GH-8842 don't set sensitive param in legacy arginfo #8921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

remicollet
Copy link
Member

No description provided.

@kocsismate
Copy link
Member

kocsismate commented Jul 4, 2022

I'm currently working on a more extensive solution for your problems, so please stay tuned for a short while :)

@TimWolla
Copy link
Member

TimWolla commented Jul 4, 2022

I'm currently working on a more extensive solution for your problems, so please stay tuned for a short while :)

Just to make sure, because it might or might not conflict: Is #8836 on your radar?

@kocsismate
Copy link
Member

Just to make sure, because it might or might not conflict: Is #8836 on your radar?

Yes, it is on my radar (the tab is open for quite a while), but i only have very limited availability for php-src so haven't had the chance yet to finish the review properly. I'll try my best this week!

@TimWolla
Copy link
Member

TimWolla commented Jul 4, 2022

so haven't had the chance yet to finish the review properly.

Perfect, no problem. I just wanted to make sure that we don't duplicate any effort.

Copy link
Member

@kocsismate kocsismate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good addition to my PR (I left it intentionally incomplete for PHP8-)

@remicollet
Copy link
Member Author

Merged as b45cd10

@remicollet remicollet closed this Jul 6, 2022
@remicollet remicollet deleted the issue-8842 branch July 6, 2022 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants