Skip to content

Set SA_ONSTACK too when zend signals are disabled and in pcntl #9758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Oct 16, 2022

Similar to #9597, but when --disable-zend-signals is passed (currently necessary when embedding PHP in Go because of #9649), and for pnctl.

@dunglas dunglas force-pushed the fix/sa-onstack-no-signals branch from 04d9d21 to c0df175 Compare October 16, 2022 10:24
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

@devnexen devnexen closed this in e6bfd7e Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants