Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally output build progress #77

Closed
asgrim opened this issue Oct 24, 2024 · 2 comments · Fixed by #83
Closed

Optionally output build progress #77

asgrim opened this issue Oct 24, 2024 · 2 comments · Fixed by #83
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@asgrim
Copy link
Collaborator

asgrim commented Oct 24, 2024

source; #76 (comment)

@asgrim see asgrim#2

I really think (especially in case of long build) user should be able to follow what happen

Perhaps if the -v option is given, to write out phpize/configure/make output, as per Remi's suggestion

@asgrim asgrim added the enhancement New feature or request label Oct 24, 2024
@remicollet
Copy link
Member

remicollet commented Oct 25, 2024

To be clear about my initial proposal (and its PoC):

For now: the task output is displayed when the task ends

Proposal: display the output during the run, especially for long task (configure in ~1', make in minutes), as without output, user may think the process is stalled.

P.S. current solution stores the output in memory, which can be very huge on some big ext. and may raise memory_limit.


Verbosity is another choice/discussion

For now: only displayed when using very verbose mode (-vvv)

IMHO: always (not in quiet mode, -q), but I'm probably not a standard user.

@asgrim asgrim self-assigned this Oct 30, 2024
@asgrim
Copy link
Collaborator Author

asgrim commented Oct 30, 2024

This will be done as part of #48

I think the current "simple" output is fine for most users, but we would display the streamed output of phpize/configure/make with a single -v. We can always revisit it if that's not the case! 👍

asgrim added a commit to asgrim/pie that referenced this issue Oct 31, 2024
asgrim added a commit to asgrim/pie that referenced this issue Nov 15, 2024
@asgrim asgrim closed this as completed in 71376be Nov 15, 2024
@asgrim asgrim added this to the 0.2.0 milestone Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants