PHP 8 release announcement #350
Conversation
|
@carusogabriel, @sgolemon, @cmb69 could you please help review the draft? Should the page go under releases/8_0_0.php? Work in progress: |
|
Thank you for the great work! I'm generally in favor of this, because in my opinion, php.net would really profit from a modern looking representation of the PHP 8.0 relase, compared to what we did so far. I assume that some may not like the style, and/or that the page doesn't integrate into the general style of php.net (if there is even a general style), so it might be best to also send a mail to the internal webmaster ML.
I think for consistency and regarding that this info is useful for following revision releases, it should not. A link to the new page could be put on releases/8_0_x.php instead. |
|
Is it intended that the |
Co-authored-by: Sergey Panteleev <sergey@php.net>
|
Translation to PT-BR ( |
Co-authored-by: Sergey Panteleev <sergey@php.net>
| function release_language_chooser($currentlang) { | ||
| $LANGUAGES = array( | ||
| 'en' => 'English', | ||
| 'pt_BR' => 'Brazilian Portuguese', |
There was a problem hiding this comment.
Odd that 'pt_BR' gets a locale, but other languages are generalized. I appreciate that's probably a quick of Brazilian Portuguese, but if the criteria is about the default being spoken more in the colonies than the mother land, then let me tell you about American English. :)
There was a problem hiding this comment.
That's the same for the PHP manual; there was pt, later came pt_BR, and now only the latter is published.
There was a problem hiding this comment.
Just an extra info: there was an international agreement that reduced the differences between european portuguese and brazilian portuguese, with full transition ended by 2016 (source)
releases/8_0_x.php
Outdated
| $_SERVER['BASE_PAGE'] = 'releases/8_0_x.php'; | ||
| include_once __DIR__ . '/../include/prepend.inc'; | ||
|
|
||
| if ($LANG !== 'en' && file_exists("8_0_x_$LANG.php")) { |
There was a problem hiding this comment.
We shouldn't trust $LANG to be sanitized by prepend.inc or whatever provided it.
Also, CWD shouldn't be assumed. This file should still render even if CWD is the root of the web checkout.
if (($LANG !== 'en') && file_exists(__DIR__ . '/8_0_x_' . basename($LANG) . '.php')) {
mirror_redirect('/releases/8_0_x.php_' . urlencode($LANG) . '.php?lang=' . urlencode($LANG));
}
Here and elsewhere in these files.
There was a problem hiding this comment.
To @cmb69's question; Yes. I think it's reasonable to get the page on the webserver ahead of time with the link not exposed yet. No problem with that. In fact, can switch it on this to make it automatic:
include __DIR__ . '/../include/version.inc';
if (!empty($GLOBALS['RELEASES'][8])) showTheLink();
As for the rest, I want anything that winds up in output (even headers) or file access escaped properly.
* add dutch translation for PHP8 splash page * fix some typos and reword some things Co-authored-by: Roman Pronskiy <root@pronskiy.com>
Co-authored-by: Roman Pronskiy <root@pronskiy.com>
|
urlencode should be added to new translation pages as well. |
|
German translation updated in naruzl#5 |
|
@SjonHortensius sorry, but I had to drop Dutch translation, because Dutch is declared as inactive and I don't see a quick way to enable it in one place and keep inactive on the rest of the site. |
|
@pronskiy I understand - I should have checked that before I did the actual translation |
| @@ -0,0 +1,797 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
I couldn't understand this image. What these numbers say?
There was a problem hiding this comment.
It shows the relative performance impact of JIT compared to PHP 8 running without JIT. For example, running PHP-Parser with Function JIT is 2.11 times faster than running it on PHP 8 with JIT disabled. Does it make sense to you?
There was a problem hiding this comment.
Maybe we should add some captions as hint? It makes sense, but at first, someone might have this same question :)
Co-authored-by: Gabriel Caruso <carusogabriel34@gmail.com>
|
I'm going to go ahead and merge this. We can still make edits, but it'll be nice to have it up on the site where we can see it. |
|
Comment on behalf of pollita at php.net: Pushed with a few of my own opinionated edits |
|
https://www.php.net/releases/8.0 is rendering 'en' for me just fine, but I don't seem to be able to change my language, so a little more tweaking is prolly necessary. Edit to add: My fault. Sigh.... ad13414 |
Implementation for PHP 8 release announcement https://externals.io/message/112026