Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Use phpunit/phpunit to run tests #605

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Enhancement: Use phpunit/phpunit to run tests #605

merged 1 commit into from
Feb 12, 2024

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Jul 3, 2022 •
edited
Loading

This pull request

  • uses phpunit/phpunit to run tests

💁‍♂️ Similar to #559, you can see this in action in localheinz#2.

@localheinz localheinz force-pushed the feature/phpunit branch 5 times, most recently from 0759dae to 95db30e Compare July 3, 2022 11:24
@localheinz localheinz mentioned this pull request Jul 3, 2022
Merged
@cmb69
Copy link
Member

cmb69 commented Jul 3, 2022

I'm not sure whether we should use PHPUnit; that's yet another third-party dependency, and it seems that PHPTs may be sufficient (at least for a while). The nice thing is that these also can be run with PHPUnit, what is especially interesting wrt. code coverage reporting.

@localheinz
Copy link
Contributor Author

@cmb69

phpunit/phpunit is the de facto industry standard for testing PHP code. I believe it is time to start using select dependencies.

@cmb69 cmb69 mentioned this pull request Jul 3, 2022
Merged
@localheinz
Copy link
Contributor Author

Closing in favour of #606 and cmb69#1.

@localheinz localheinz closed this Jul 3, 2022
@localheinz localheinz deleted the feature/phpunit branch July 3, 2022 13:50
@localheinz localheinz restored the feature/phpunit branch December 11, 2023 15:38
@localheinz localheinz reopened this Dec 11, 2023
@localheinz localheinz marked this pull request as draft December 11, 2023 15:38
@localheinz localheinz changed the title Enhancement: Run phpunit/phpunit on GitHub Actions Enhancement: Use phpunit/phpunit to run tests Dec 11, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2023 •
edited
Loading

🚀 Commit ff36297 Deployed on https://web-php-pr-605.preview.thephp.foundation

@localheinz localheinz force-pushed the feature/phpunit branch 2 times, most recently from 62de7be to 8f93328 Compare December 11, 2023 16:19
@github-actions GitHub Actions
Copy link

🚀 Deployed on https://web-php-pr-605.preview.thephp.foundation

@github-actions GitHub Actions
Copy link

🚀 Deployed on https://web-php-pr-605.preview.thephp.foundation

@localheinz localheinz force-pushed the feature/phpunit branch 2 times, most recently from a7a6791 to 01dffd8 Compare December 11, 2023 16:21
@github-actions GitHub Actions
Copy link

🚀 Deployed on https://web-php-pr-605.preview.thephp.foundation

1 similar comment
@github-actions GitHub Actions
Copy link

🚀 Deployed on https://web-php-pr-605.preview.thephp.foundation

@github-actions GitHub Actions
Copy link

🚀 Deployed on https://web-php-pr-605.preview.thephp.foundation

1 similar comment
@github-actions GitHub Actions
Copy link

🚀 Deployed on https://web-php-pr-605.preview.thephp.foundation

@localheinz localheinz marked this pull request as ready for review December 11, 2023 16:22
@localheinz
Copy link
Contributor Author

@cmb69 @kamil-tekiela

I have reopened this pull request because I believe we are at a point where we would benefit from using phpunit/phpunit.

What do you think?

@localheinz localheinz mentioned this pull request Dec 14, 2023
Merged
1 task
@derickr derickr merged commit f24c916 into php:master Feb 12, 2024
3 checks passed
@localheinz localheinz deleted the feature/phpunit branch February 12, 2024 17:42
@localheinz
Copy link
Contributor Author

Thank you, @cmb69, @derickr, and @saundefined!

@localheinz localheinz mentioned this pull request Feb 12, 2024
Merged
1 task
@TomasVotruba
Copy link

Thank you @localheinz for great improvement 👏

This was referenced Feb 13, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@localheinz @cmb69 @TomasVotruba @derickr @saundefined