Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitlab CI test failure #21

Closed
php1ic opened this issue Jul 12, 2020 · 4 comments
Closed

Gitlab CI test failure #21

php1ic opened this issue Jul 12, 2020 · 4 comments

Comments

@php1ic
Copy link
Owner

php1ic commented Jul 12, 2020 •
edited
Loading

Gitlab CI expands Options::getAbolutePath() to be relative causing tests to fail.

See 708fea2 and the pipeline logs for different CI providers:
GitlabCI, Test 48 - "../data_files/"
https://gitlab.com/php1ic/inch/-/jobs/634917536
CircleCI, Test 48 - "/home/circleci/project/data_files/"
https://app.circleci.com/pipelines/github/php1ic/inch/210/workflows/32a5ee0e-10b7-4a8a-bafa-21130cfd2e4a/jobs/808
AppVeyor, Test 25 - "C:\projects\inch\data_files\"
https://ci.appveyor.com/project/php1ic/inch/builds/34050948/job/fi3x64xxxj1am0oi

Gitlab and CircleCI are both use gcc 8.4.0. So issue looks to be gitlab related,
php1ic added a commit that referenced this issue Jul 12, 2020
@php1ic
Revert gitlab-ci config, it was not wrong
e42b088 
There is an issue with gitlab-ci and getting absolute paths. This is
tracket in #21 of inch.
@php1ic php1ic closed this as completed in 1b36511 Jul 22, 2020
@php1ic php1ic reopened this Jul 22, 2020
@php1ic
Copy link
Owner Author

php1ic commented Jul 22, 2020

Not fixed, need to watch my wording in commit messages.

php1ic added a commit that referenced this issue Jul 22, 2020
@php1ic
Will a prallel build directory help
64d8971 
Working on #21
php1ic added a commit that referenced this issue Jul 22, 2020
@php1ic
Use correct artifacts path
ef86217 
Still on #21
php1ic added a commit that referenced this issue Jul 22, 2020
@php1ic
You can't use a parallel build dir on gitlab
8cc5748 
Should have done #21 work on a branch.
php1ic added a commit that referenced this issue Jul 22, 2020
@php1ic
Write out values to try and debug
64b58cb 
Still on #21
@php1ic
Copy link
Owner Author

php1ic commented Jul 24, 2020

Gitlab clones to - /builds/php1ic/inch/
This build directory /builds/php1ic/inch/build is created and then passed between stages via the path:artifacts.
Everything looks good in the test stage

$ cd ./build
$ ctest -j2 -V
UpdateCTestConfiguration  from :/builds/php1ic/inch/build/DartConfiguration.tcl
UpdateCTestConfiguration  from :/builds/php1ic/inch/build/DartConfiguration.tcl
Test project /builds/php1ic/inch/build

However the path to the data files is set as - "/builds/php1ic/inch/build/tests/../data_files/" and this causes the failure.

php1ic added a commit that referenced this issue Jul 26, 2020
@php1ic
Don't split gitlab CI into stages
b391506 
It seems a bit of a waste as eaxh stage pulls a new docker image.
Does this help with #21
@php1ic
Copy link
Owner Author

php1ic commented Sep 25, 2020

I've removed the stages from gitlab so everything is done in the same container and nothing is passed via artifacts, but it is still setting the path as "/builds/php1ic/inch/build/tests/../data_files/"

Thinking out loud, I can't even see where this part of the path - /builds/php1ic/inch/build/tests/.. - is coming from.

@php1ic php1ic mentioned this issue Sep 26, 2020
Open
@php1ic
Copy link
Owner Author

php1ic commented Sep 26, 2020

Closing as not an issue with gitlab CI. See #22

@php1ic php1ic closed this as completed Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@php1ic