Skip to content

Do not include config files twice #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2023
Merged

Do not include config files twice #768

merged 1 commit into from
Dec 19, 2023

Conversation

wouterj
Copy link
Contributor

@wouterj wouterj commented Dec 19, 2023

Imagine this file structure:

project/
 + docs/
 + vendor/
 |   + phpdocumentor/
 |       + guides-cli/
 + guides.xml

Running the CLI from the project root would result in guides.xml to be loaded twice. This PR fixes it, and also improves the verbose output by resolving all the /../ parts in the filepath.

@jaapio jaapio enabled auto-merge December 19, 2023 16:24
@jaapio jaapio merged commit 15a47e4 into phpDocumentor:main Dec 19, 2023
@wouterj wouterj deleted the config-output branch December 19, 2023 16:28
@greg0ire greg0ire mentioned this pull request Jan 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaapio jaapio jaapio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wouterj @jaapio