[TASK] Trait for database test, base class for web tests #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtuke
approved these changes
Feb 15, 2018
Collaborator
|
From PHPMD: |
Contributor
Author
|
On it. |
The trait DatabaseTestTrait and the class abstractWebTest now are available to be used in other packages as well, reducing code duplication. Also whitelist two more static calls in the PHPMD configuration and break a long line in the PHPMD configuration file.
oliverklee
force-pushed
the
task/integration-tests
branch
from
355996d to
227091d
Compare
Contributor
Author
|
Fixed and repushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trait DatabaseTestTrait and the class abstractWebTest now are
available to be used in other packages as well, reducing code
duplication.