simplify init

[fain182]

I am not sure about this one, the different includes seems redundant, without this code the CI is green...
Any additional test we can make to check if this is useful?

[AlessandroMinoccheri]

Did you try to generate the phar file without those lines and verify that it works fine?
Can we automate this check?

• Generate phar
• using phar with some rule with some files

[fain182]

I tried to generate the phar (with make phar) but it failed, even on the main branch..

But if I understand correctly the github action make a smoke test on the phar:
https://github.com/phparkitect/arkitect/blob/main/.github/workflows/build.yml#L116

[AlessandroMinoccheri]

The smoke test was done for that: test the phar generation.
@micheleorselli what do you think?

[AlessandroMinoccheri]

Which error do you get @fain182 ?
It's about /tmp/.. permission, right?

[micheleorselli]

AFAIK the only thing the above code is supposed to do is setting PHPARKITECT_COMPOSER_INSTALL as a way to say the package was installed via composer 🤔

To me it can be safely removed

On the other hand, I am not totally sure about adding this line: what is it effect?

[fain182]

To me seems more like:

• try to find and autoloader (why? it's always in the same place)
• setup a warning if composer install has not been executed yet
• include the autoload

The situation is different if we are searching the autoload of the project ouside of the phar, but I don't think it's this case.

[micheleorselli]

you are totally right... let's remove it then

[fain182]

Which error do you get @fain182 ? It's about /tmp/.. permission, right?

the first error is:

bin/box.phar compile -c /tmp/arkitect/box.json
make: bin/box.phar: Permesso negato
make: *** [Makefile:26: phar] Errore 127

If I correct the permission, it says something strange about PHP versions...

[micheleorselli]

Which error do you get @fain182 ? It's about /tmp/.. permission, right?

the first error is:

bin/box.phar compile -c /tmp/arkitect/box.json
make: bin/box.phar: Permesso negato
make: *** [Makefile:26: phar] Errore 127

If I correct the permission, it says something strange about PHP versions...

If I remember correctly, the Box version we have works fine php 7.1, which is the version we use to generate the phar. Other 7.x version should work, 8.x version will not. More recent Box version will work with php 8, but they dropped the support for php 7.1

Long story short, if you want to generate the phar you need to have php 7