-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pattern match #404
base: main
Are you sure you want to change the base?
Fix pattern match #404
Conversation
a7e3e5e
to
7d7e9c1
Compare
Thanks for you contributions! As you can see from the broken tests this function is used in a lot of places, and reverting to an old behavior is not a valid solution... |
Reverting the changes and leaving the test as is, we can see that this assertion fails: $pattern = new PatternString('SoThisIsAnExample');
$this->assertFalse($pattern->matches('*This')); However, it shouldn't fail because it shouldn't match since there is no wildcard at the end of the string. |
@fain182 |
@fain182 I believe I fixed the issues, can you check the last commits, please? |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #404 +/- ##
============================================
- Coverage 94.33% 94.31% -0.02%
+ Complexity 571 570 -1
============================================
Files 67 67
Lines 1500 1495 -5
============================================
- Hits 1415 1410 -5
Misses 85 85
|
At some point this was correct and then changed into a bug.
I am reverting the change that introduced the bug.