Extend some test coverage

phpbb · Nov 30, 2023 · 7421628 · 7421628
1 parent 55dbd4d
commit 7421628
Show file tree

Hide file tree

Showing 2 changed files with 80 additions and 0 deletions.
diff --git a/tests/GithubLabelsTest.php b/tests/GithubLabelsTest.php
@@ -63,6 +63,7 @@ public function dataHandleEmpty(): array
             ['!unset Event', [], ['Event']],
             ['!unset GSOC 🎓', [], ['GSOC 🎓']],
             ['!unset GSOC', [], ['GSOC 🎓']],
+            ['!unset LOL', [], []], // Label does not exist
         ];
     }
 

diff --git a/tests/KernelTest.php b/tests/KernelTest.php
@@ -45,4 +45,83 @@ public function testHandle()
 
         $this->kernel->handle($body, $server);
     }
+
+    public function testMissingEventHeader()
+    {
+        $payload = [];
+        $body = json_encode($payload);
+        $server = [
+            'HTTP_X_HUB_SIGNATURE' => 'sha1='.hash_hmac('sha1', $body, $this->hmacKey),
+        ];
+        $listenerStub = $this->createMock('Phpbb\DevHooks\Listener\Listener');
+        $listenerStub
+            ->expects($this->never())
+            ->method('handle')
+        ;
+
+        $this->container['listener.test_event.test'] = $listenerStub;
+
+        $this->expectException(\UnexpectedValueException::class);
+        $this->expectExceptionMessage('Missing X-Github-Event header.');
+        $this->kernel->handle($body, $server);
+    }
+
+    public function testMissingSignature()
+    {
+        $body = '';
+        $server = [
+            'HTTP_X_GITHUB_EVENT' => 'test_event',
+        ];
+        $listenerStub = $this->createMock('Phpbb\DevHooks\Listener\Listener');
+        $listenerStub
+            ->expects($this->never())
+            ->method('handle')
+        ;
+
+        $this->container['listener.test_event.test'] = $listenerStub;
+
+        $this->expectException(\UnexpectedValueException::class);
+        $this->expectExceptionMessage('Missing X-Hub-Signature header');
+        $this->kernel->handle($body, $server);
+    }
+
+    public function testInvalidSignature()
+    {
+        $body = '';
+        $server = [
+            'HTTP_X_HUB_SIGNATURE' => 'sha1=invalid',
+            'HTTP_X_GITHUB_EVENT' => 'test_event',
+        ];
+        $listenerStub = $this->createMock('Phpbb\DevHooks\Listener\Listener');
+        $listenerStub
+            ->expects($this->never())
+            ->method('handle')
+        ;
+
+        $this->container['listener.test_event.test'] = $listenerStub;
+
+        $this->expectException(\UnexpectedValueException::class);
+        $this->expectExceptionMessage('Incorrect X-Hub-Signature header');
+        $this->kernel->handle($body, $server);
+    }
+
+    public function testEmptyPayload()
+    {
+        $body = '';
+        $server = [
+            'HTTP_X_HUB_SIGNATURE' => 'sha1='.hash_hmac('sha1', $body, $this->hmacKey),
+            'HTTP_X_GITHUB_EVENT' => 'test_event',
+        ];
+        $listenerStub = $this->createMock('Phpbb\DevHooks\Listener\Listener');
+        $listenerStub
+            ->expects($this->never())
+            ->method('handle')
+        ;
+
+        $this->container['listener.test_event.test'] = $listenerStub;
+
+        $this->expectException(\UnexpectedValueException::class);
+        $this->expectExceptionMessage('Expected payload to be array.');
+        $this->kernel->handle($body, $server);
+    }
 }