Invalid method argument in NodeViewTest

[piotras]

There were 2 errors:

1. PHPCR\Tests\Query\NodeViewTest::testSeekable
   ArrayIterator::seek() expects parameter 1 to be long, string given

api-test/suite/tests/06_Query/NodeViewTest.php:40

2. PHPCR\Tests\Query\NodeViewTest::testSeekableOutOfBounds
   ArrayIterator::seek() expects parameter 1 to be long, string given

api-test/suite/tests/06_Query/NodeViewTest.php:51

[dbu]

weird. according to http://php.net/manual/en/class.arrayiterator.php, seek expects an integer, while the key() method returns mixed. which violates the SeekableInterface the ArrayIterator implements.

and a seek without mixed is pretty useless if your keys are not numbers...

@lsmith77: can you maybe give us some input here? this behaviour seems to have changed between php 5.3.3 and 5.3.5. any idea what would be correct here?

the test in question basically does

    $seekNodeName = '/tests_general_base/index.txt/jcr:content';
    $this->nodeIterator->seek($seekNodeName);

[lsmith77]

seeking isnt done to a key .. but to a position aka offset inside the array

[dbu]

seems we ran into a php bug here that has been fixed. on 5.3.3 you can only seek with a string in an arrayiterator. but according to the doc, the seek key must be an integer. however, seeking for an integer in arrayiterator gives me an OutOfBoundsException. i changed jackalope to skip the seek test if php is not newer than 5.3.3

@piotras: can you please check if this is now working correctly and close the issue if so?

[piotras]

No more warnings. Closing.

[dbu]

i am not so sure of this anymore. seems piotras was using something with numerical keys as well. could this be a bug in the php doc? that you can have whatever as key and seek happens with that "whatever" and not always with numerical positions?
or is it really something that was fixed in php 5.3.5 ?

[piotras]

Yep, I created invalid iterator which propagated integers as keys. But it's not related to this issue:

$seekNodeName = '/tests_general_base/index.txt/jcr:content';
$this->nodeIterator->seek($seekNodeName);