Skip to content

Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2017
Merged

Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase #185

merged 1 commit into from
Nov 12, 2017

Conversation

carusogabriel
Copy link
Contributor

I use the PHPUnit\Framework\TestCase notation instead of PHPUnit_Framework_TestCase while extending our TestCases. This will help us migrate to PHPUnit 6, that no longer support snake case class names.

@dbu
Copy link
Member

dbu commented Nov 10, 2017

i fixed the styleci issues in master. the change looks right to me.

can you please do pull requests on jackalope-jackrabbit and jackalope-doctrine-dbal that start using this branch? there is no travis-ci for this repository, it just contains the functional tests for phpcr and is run in those two repos.

something like:

    "repositories": [
        {
            "type": "git",
            "url": "git@github.com:gabriel-caruso/phpcr-api-tests.git"
        },
       require: {
            "phpcr/phpcr-api-tests": "dev-phpunit as 2.1"
       }

@dbu
Copy link
Member

dbu commented Nov 12, 2017

looks good in jackalope/jackalope-jackrabbit#150 and jackalope/jackalope-doctrine-dbal#346 ! thanks.

shall i tag a release already or not yet? do you plan on updating jackalope/* repositories now?

@carusogabriel
Copy link
Contributor Author

@dbu Target it, please, I’ll work on then as soon as possible

@carusogabriel carusogabriel deleted the phpunit branch November 12, 2017 21:08
@dbu
Copy link
Member

dbu commented Nov 12, 2017

just tagged 2.1.18 with this, thanks!

@dbu
Copy link
Member

dbu commented Nov 12, 2017

note that in jackalope, the composer.json references a specific version of the api tests, not a range. each new test added might fail with the repository, so we want to upgrade controlled. when you do the PRs, just change the composer.json line to 2.1.18

btw, there is also jackalope/jackalope with the common things which will be affected by this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants