Skip to content

Fix expected exception in RepositoryTest #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2020
Merged

Fix expected exception in RepositoryTest #192

merged 1 commit into from
Feb 12, 2020

Conversation

alexander-schranz
Copy link
Contributor

@alexander-schranz alexander-schranz commented Feb 11, 2020 •
edited
Loading

When using PhpUnit 7 setExpectedException is not available since phpunit 5.2 it should be expectException.

@alexander-schranz alexander-schranz mentioned this pull request Feb 11, 2020
Merged
dbu
dbu approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. seems we already use the new method name for most expectations.

@dbu dbu merged commit 9847773 into phpcr:master Feb 12, 2020
@alexander-schranz alexander-schranz deleted the bugfix/expected-exception branch February 12, 2020 07:50
@alexander-schranz alexander-schranz mentioned this pull request Apr 24, 2020
Merged
66 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-schranz @dbu