Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding class+interface constants #171

Merged
merged 6 commits into from
Feb 12, 2025
Merged

adding class+interface constants #171

merged 6 commits into from
Feb 12, 2025

Conversation

brettmc
Copy link
Contributor

@brettmc brettmc commented Feb 11, 2025

  • allow ClassEntity.add_constant and InterfaceEntity.add_constant, which will call zend_declare_class_constant_*
  • update documentation

brettmc and others added 6 commits February 12, 2025 09:02
jmjoy
jmjoy approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@jmjoy jmjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your high quality PR.

@jmjoy jmjoy merged commit 9d3b15c into phper-framework:master Feb 12, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmjoy jmjoy jmjoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brettmc @jmjoy