Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: rename bind_* to bound_* #192

Merged
merged 1 commit into from
Apr 3, 2025
Merged

Conversation

jmjoy
Copy link
Member

@jmjoy jmjoy commented Apr 3, 2025

bound semantics are more precise.


This pull request primarily focuses on renaming several methods and variables in the phper library to improve code clarity and consistency. The changes involve renaming the bind_class and bind_interface methods and variables to bound_class and bound_interface respectively.

Key changes include:

Method and Variable Renaming in phper/src/classes.rs:

  • Renamed bind_class to bound_class in the ClassEntity struct and its methods. [1] [2] [3] [4] [5]
  • Renamed bind_interface to bound_interface in the InterfaceEntity struct and its methods. [1] [2] [3] [4]

Updates in phper/src/modules.rs:

  • Updated the add_class and add_interface methods in the Module struct to use bound_class and bound_interface respectively.

Test Adjustments:

  • Modified the test files to reflect the renaming changes in method calls and comments. [1] [2]

These changes ensure that the naming conventions are more intuitive and consistent across the codebase.

@jmjoy jmjoy requested a review from Copilot April 3, 2025 03:09
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the clarity and consistency of the phper library by renaming binding methods and variables from "bind_" to "bound_."

  • Renamed methods and fields in ClassEntity from bind_class to bound_class.
  • Renamed methods and fields in InterfaceEntity from bind_interface to bound_interface.
  • Updated module functions and integration tests to reflect the new naming.

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
tests/integration/src/classes.rs Updated integration test to use bound_class instead of bind_class.
phper/src/modules.rs Changed add_class and add_interface to return the renamed bound_* values.
phper/src/classes.rs Renamed fields, methods, and comments in both ClassEntity and InterfaceEntity to use bound_*.
Files not reviewed (1)
  • tests/integration/tests/php/classes.php: Language not supported

@jmjoy jmjoy merged commit 58fef19 into phper-framework:master Apr 3, 2025
22 checks passed
@jmjoy jmjoy deleted the bound branch April 3, 2025 03:13
This was referenced Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants