adding function start and end line number #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function line number represents the first line of the definition of the currently executing function, which can differ from execute_data.opcode rename execute_data.get_lineno to get_opline_lineno to better describe what the value is
class_name was a bug, but I missed the doc update when fixing this previously
expose op_array.line_start and line_end, per https://github.com/php/php-src/blob/master/Zend/zend_compile.h#L548
jmjoy
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to function introspection in the
phperlibrary and updates documentation to reflect a more accurate parameter type. The most important changes are the addition of new methods for retrieving a function's declaration line numbers, a clarification in a documentation example, and a minor renaming for clarity.Function Introspection Enhancements:
get_line_startandget_line_endmethods to theZFuncstruct inphper/src/functions.rs, allowing retrieval of the start and end line numbers for user-defined and evaluated functions.Documentation Update:
phper-doc/doc/_06_module/_02_register_functions/index.mdto show the parameter type as?\MyNamespace\MyInterfaceinstead of?class_name, reflecting the actual interface type used.Codebase Consistency:
get_linenotoget_opline_linenoin theExecuteDatastruct inphper/src/values.rsfor improved clarity regarding its purpose.