-
Notifications
You must be signed in to change notification settings - Fork 20
make leaner bindings #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iterate over the php include directories, and update the builder to only create bindings from the header files in those directories php_bindings.rs become 14000 lines smaller 48803 php_bindings.rs.old 34222 php_bindings.rs also fixed compile errors related to the _Float64x type no functions using it are in the bindings any more
just an example of the compile failures before this patch
|
gdamjan
added a commit
to gdamjan/ruwstgi
that referenced
this pull request
Nov 17, 2022
nothing much to see really also, now waiting for phper-framework/phper#63
much easier on the eyes
I think you should pass the CI and then I can review it. |
jmjoy
approved these changes
Dec 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your excellent work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iterate over the php include directories, and update the builder to only create bindings from the header files in those directories. This omits all of the other non-php related types and functions from the bindings, and avoids the need to explicitly add hundreds of functions to the blocklist.
With that
php_bindings.rs
also become 14000 lines smaller48803 php_bindings.rs.old
34222 php_bindings.rs
also fixed compile errors related to the _Float64x type no functions using it are in the bindings any more