Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Issues upserting by ID and specifying nillable fields #19

Merged
merged 1 commit into from
Apr 5, 2015

Conversation

ikrasnykh
Copy link
Contributor

Since every object extends sObject, need to append sObject elements to all native and custom objects

@@ -40,6 +40,12 @@ public function getSoapTypes()
preg_match('/\s* (.*) (.*);/', $line, $matches);
$properties[$matches[2]] = $matches[1];
}

// IK 4.4.2015: Since every object extends sObject, need to append sObject elements to all native and custom objects
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does IK mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove that comment prefix

@ddeboer
Copy link
Member

ddeboer commented Apr 5, 2015

Thanks, could you please squash your commits?

@ikrasnykh
Copy link
Contributor Author

Squashed commits. Let me know if you need any additional help

ddeboer added a commit that referenced this pull request Apr 5, 2015
Fix: Issues upserting by ID and specifying nillable fields
@ddeboer ddeboer merged commit df1d065 into phpforce:master Apr 5, 2015
@ddeboer
Copy link
Member

ddeboer commented Apr 5, 2015

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants