Skip to content

breaking(core): migrate to svelte-kit + revamp ui #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 7, 2022

Conversation

mazipan
Copy link
Member

@mazipan mazipan commented Jan 1, 2022

Trying svelte-kit x TS x Tailwind

I am working on my-app directory, so please do these step to run on your local:

cd my-app
yarn
yarn dev

Homepage Route

  • Move svelte/stores
  • Move utils
  • Move statics dir
  • Move dummy data
  • Set static adapter for SSG
  • Body background seems already cropped, need the full version before masked in figma. I think it will show better on background-repeat --> @itsfaqih
  • Hero
  • Card List
  • Pagination
  • Menu on Mobile
  • Theme switcher
  • Double check all stylings to follow Figma

Search Route

  • Routes component
  • Hero for search

Tag Route

  • Routes component
  • Hero for tag page

Final preparations

  • Remove unused files
  • Prepare static site generation for dynamic page such as tag page
  • Remove old Apps
  • Update CI on GH Actions

Why Svelte-kit?

Pros

  • Easy migration
  • The DX is getting better than the old sapper
  • No need to manual generate static paths

Cons

  • No significant improvement -- maybe worst because we include Tailwind

@mazipan
Copy link
Member Author

mazipan commented Jan 6, 2022

@itsfaqih if you have a free time, maybe you wanna help me on this page styling?

@itsfaqih
Copy link
Contributor

itsfaqih commented Jan 6, 2022

@itsfaqih if you have a free time, maybe you wanna help me on this page styling?

Sure! Are you doing any styling right now?
Just to make sure there's no overlap

@mazipan
Copy link
Member Author

mazipan commented Jan 6, 2022

I am DONE @itsfaqih, and maybe will not active for few days ahead.

@mazipan mazipan changed the title feat: init commit svelte-kit breaking(core): migrate to svelte-kit + revamp ui Jan 6, 2022
irfan-maulana-tkp and others added 10 commits January 7, 2022 09:26
* chore(config): change 'purge' to 'content' in tailwind config

* chore(style): add more styling

* chore(styling): hide pagination number in smaller screen

* chore(styling): add consistent padding for smaller screen

* chore(styling): remove padding on larger screen
@mazipan mazipan marked this pull request as ready for review January 7, 2022 02:27
@mazipan mazipan merged commit d365024 into master Jan 7, 2022
@mazipan mazipan deleted the feature/try-svelte-kit branch January 7, 2022 02:56
mazipan added a commit that referenced this pull request Jan 7, 2022
* feat: init commit svelte-kit

* feat: add base homepage skeleton

* feat: entries

* feat: update style

* chore(style): add some stylings

* chore(style): add more stylings

* chore(styles): add more accurate styling to svelte kit version (#105)

* chore(config): change 'purge' to 'content' in tailwind config

* chore(style): add more styling

* chore(styling): hide pagination number in smaller screen

* chore(styling): add consistent padding for smaller screen

* chore(styling): remove padding on larger screen

* feat(page): search + tag page

* fix(build): change read query onMount

* feat(core): update to mainApp

* chore: format

* fix: missing 3rd party

Co-authored-by: Irfan Maulana (@mazipan) <maulana.irfan@tokopedia.com>
Co-authored-by: Muhammad Faqih Muntashir <48067039+itsfaqih@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants