-
-
Notifications
You must be signed in to change notification settings - Fork 48
breaking(core): migrate to svelte-kit + revamp ui #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@itsfaqih if you have a free time, maybe you wanna help me on this page styling? |
Sure! Are you doing any styling right now? |
I am DONE @itsfaqih, and maybe will not active for few days ahead. |
* chore(config): change 'purge' to 'content' in tailwind config * chore(style): add more styling * chore(styling): hide pagination number in smaller screen * chore(styling): add consistent padding for smaller screen * chore(styling): remove padding on larger screen
d422398
to
646b06b
Compare
mazipan
added a commit
that referenced
this pull request
Jan 7, 2022
* feat: init commit svelte-kit * feat: add base homepage skeleton * feat: entries * feat: update style * chore(style): add some stylings * chore(style): add more stylings * chore(styles): add more accurate styling to svelte kit version (#105) * chore(config): change 'purge' to 'content' in tailwind config * chore(style): add more styling * chore(styling): hide pagination number in smaller screen * chore(styling): add consistent padding for smaller screen * chore(styling): remove padding on larger screen * feat(page): search + tag page * fix(build): change read query onMount * feat(core): update to mainApp * chore: format * fix: missing 3rd party Co-authored-by: Irfan Maulana (@mazipan) <maulana.irfan@tokopedia.com> Co-authored-by: Muhammad Faqih Muntashir <48067039+itsfaqih@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying svelte-kit x TS x Tailwind
I am working on
my-app
directory, so please do these step to run on your local:cd my-app yarn yarn dev
Homepage Route
background-repeat
--> @itsfaqihSearch Route
Tag Route
Final preparations
tag
pageWhy Svelte-kit?
Pros
Cons