pass TokenCollection instead of Tokenizer to Metrics #208
Conversation
|
to calculate peak memory usage, i added $output->writeln(memory_get_peak_usage(true) . ' bytes used'); to the end of RunMetricsCommand.php |
| @@ -1,42 +0,0 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Why did you removed this file ?
There was a problem hiding this comment.
it was no longer used anywhere in the code base (i checked carefully). can easily put it back if you think it needed? I thought it is not a BC break because phpmetrics is an independent "app", not like a library with a public interface that needs a major version bump for a change like that... maybe i was wrong?
|
Hum, I prefer 2 PR:
Thanks a lot ! |
| @@ -101,18 +100,18 @@ public function execute(ResultCollection $collection, ResultCollection $aggregat | |||
|
|
|||
| // tools | |||
| $classMap = new ClassMap(); | |||
| $tokenizer = new Tokenizer(new CacheMemory()); | |||
There was a problem hiding this comment.
@pavarnos Cache is used at least here 😉
There was a problem hiding this comment.
yes... in the current master branch. But once this pull request is merged the code does not need it. (I searched through the whole code base: "CacheMemory" is not mentioned anywhere). Tokenizer now has no constructor.
|
@pavarnos you made a really hard work 👍. On my computer, PhpMetrics is around 20% faster 😎 I'll merge as soon you will revert your changes about cache. |
|
Please be patient @pavarnos , I hope I'll merge tomorrow :) |
for #188. Tokenizer was caching all the tokens for all files in the whole project. It didn't need to: each file is processed in turn and only the processed results are kept for analysis. Refactored to pass a TokenCollection to Metrics instead of the Tokenizer. Removed the Cache (no longer needed)